Hi @stefanmcshane. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

/assign AndiDog

/ok-to-test

/test pull-cluster-api-provider-aws-verify

make verify-modules works locally without error

/retest

failed: No matching PR type indicator found in title. – please go through the checklist in the PR template

apidiff differences look fine since only new SDK function signatures were added, AFAICS. Only the the PR formalities must be fixed, I think.

/lgtm

Made all the necessary changes @AndiDog. Let me know if you need anything else 😄

The commit contains lots of unrelated changes. Probably a rebase mistake?

Thank you for this PR @stefanmcshane
Could you please rebase your PR against main?
TY

/lgtm

but must be rebased

I'd love to get this in and backported:

/cherrypick release-2.4

@richardcase: once the present PR merges, I will cherry-pick it on top of release-2.4 in a new PR and assign it to you.

@stefanmcshane - would you be able to rebase this and then i will approve.

Thanks @stefanmcshane.

/test ?

@richardcase: The following commands are available to trigger required jobs:

• /test pull-cluster-api-provider-aws-build
• /test pull-cluster-api-provider-aws-build-docker
• /test pull-cluster-api-provider-aws-test
• /test pull-cluster-api-provider-aws-verify

The following commands are available to trigger optional jobs:

• /test pull-cluster-api-provider-aws-apidiff-main
• /test pull-cluster-api-provider-aws-e2e
• /test pull-cluster-api-provider-aws-e2e-blocking
• /test pull-cluster-api-provider-aws-e2e-clusterclass
• /test pull-cluster-api-provider-aws-e2e-conformance
• /test pull-cluster-api-provider-aws-e2e-conformance-with-ci-artifacts
• /test pull-cluster-api-provider-aws-e2e-eks
• /test pull-cluster-api-provider-aws-e2e-eks-gc
• /test pull-cluster-api-provider-aws-e2e-eks-testing

Use /test all to run the following jobs that were automatically triggered:

• pull-cluster-api-provider-aws-apidiff-main
• pull-cluster-api-provider-aws-build
• pull-cluster-api-provider-aws-build-docker
• pull-cluster-api-provider-aws-test
• pull-cluster-api-provider-aws-verify

Just in case:

/test pull-cluster-api-provider-aws-e2e-eks

/lgtm
/approve

Until the e2e passes:

/hold

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: richardcase

The full list of commands accepted by this bot can be found here.

The pull request process is described here

The e2e passed so:

/unhold

@richardcase: #4916 failed to apply on top of branch "release-2.4":

Applying: bump aws version
Using index info to reconstruct a base tree...
M	go.mod
M	go.sum
Falling back to patching base and 3-way merge...
Auto-merging go.sum
CONFLICT (content): Merge conflict in go.sum
Auto-merging go.mod
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 bump aws version
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".